Coding Horrors

// Names have been changed to protect the guilty...
//
namespace OMG
{
    static class TranslationClass
    {
        static ArrayList nonTranslatable = new ArrayList();

        public static ArrayList NonTranslatable
        {
            get
            {
                nonTranslatable.Add("1st String");
                nonTranslatable.Add("2nd String");
                // ...
                nonTranslatable.Add("30th String");
                return nonTranslatable;
            }
        }
 
        private SortedList translationDictionary = new SortedList();
 
        // more stuff here to fill the translationDictionary
 
        public void TranslateNode(XmlNode node)
        {
            foreach (string s in NonTranslatable)
            {
                if (node.Attributes["Publish"].InnerText.Trim().Contains(s))
                {
                    return;
                }
            }
 
            foreach (DictionaryEntry de in translationDictionary)
            {
                if (de.Key.ToString().Equals(node.Attributes["Publish"].InnerText.Trim()))
                    node.Attributes["Publish"].InnerText
                            = translationDictionary[node.Attributes["Publish"].InnerText.Trim()].ToString();
            }
        }
    }
}

PIEBALDconsult wrote:

And how about removing the .ToString and .Equals ?

Chris Meech wrote:

The slower they work, the better.

Line 61: 		}
Line 62: 		if (IsRequiredField('<%= txtExpDate.ClientID %>', 'Expiry Date', errorLbl) == false)
Line 63: 		if (f.value==1)

private void ClearFields()
{
   this.txtCouponCode.Text="";
   this.txtCouponName.Text="";
   this.txtDiscount.Text="";
   this.txtNoUses.Text="";
   this.ddlNoUses.SelectedIndex=1;
   this.txtExpDate=null; // WTF!!!!!!
}

    if (x == 0)
    {
        y = 0;
    }
    else
    {
        y = x;
    }

if (x == 0)
    {
        if (y != 0)
            {
                y = 0;
            }
    }
    else
    {
        if (y != x)
            {
                y = x;
            }
    }

{
  double x1,x2,z1,z2;

  x1= 1e-30/1e30;  /* x1 is positive zero */
  x2=-1e-30/1e30;  /* x2 is negative zero */
  z1=1/x1;         /* z1 is positive infinity */
  z2=1/x2;         /* z2 is negative infinity */
}

function toggleDiv(divName)
{
    $(divName).toggle();
}